Adding latest tag for catalog index image #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkumatag
requested changes
Dec 9, 2024
Signed-off-by: Varad Ahirwadkar <[email protected]>
varad-ahirwadkar
force-pushed
the
catalog
branch
from
b18094d to
3afbdb1
Compare
mkumatag
requested changes
Dec 9, 2024
| rm -rf $(TMP_DIR) | ||
| rm -rf $(TMP_DIR).Dockerfile |
There was a problem hiding this comment.
If you are removing the directory itself in the above command, why do you need to delete this files explicitly?
There was a problem hiding this comment.
It creates both a temporary directory and a temporary Dockerfile in the current directory.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, varad-ahirwadkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
merged commit 0eb10f1
into
ocp-power-automation:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.