This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
Updates the Issues API to use the new pattern #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, @dhruvsinghal. Mind tackling #72 as part of this PR? |
| } | ||
| url, err := uri.Expand(uriParams) | ||
| if err != nil { | ||
| return make([]Issue, 0), &Result{Err: err} |
There was a problem hiding this comment.
Any reason to return an empty array here rather than nil?
There was a problem hiding this comment.
My bad: I didn't realize that you could return nil in place of slices.
|
@pengwynn Please take a look. |
|
@dhruvsinghal ^note on the comment above |
|
@pengwynn Please take yet another look. |
|
@dhruvsinghal Looks good. We'll merge after we figure out what's up with CI. |
pengwynn
added a commit
that referenced
this pull request
Apr 28, 2015
Updates the Issues API to use the new pattern
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pengwynn please take a look.