Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] chart: keep data series when switching chart types #5263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hokolomopo
Copy link
Contributor

Description

Currently if you have a bar chart with 3 ranges, switch to a gauge chart that only accept a single range, then back to a bar chart you will lose the 2 other ranges.

This commit fixes that. The ranges are kept in the store so we can switch between chart types without losing data.

There is one issue however: we do not make any difference between ranges lost because the chart type changed, and ranges lost because the user manually removed them. So if a user change chart type => remove a range => change chart type again, the removed range will be back.

This commit also fixed another issue that the chart creation context was not dependant on which figure was edited.

Task: 4282798

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Currently if you have a bar chart with 3 ranges, switch to a gauge
chart that only accept a single range, then back to a bar chart you
will lose the 2 other ranges.

This commit fixes that. The ranges are kept in the store so we can
switch between chart types without losing data.

There is one issue however: we do not make any difference between
ranges lost because the chart type changed, and ranges lost because
the user manually removed them. So if a user change chart type =>
remove a range => change chart type again, the removed range will
be back.

This commit also fixed another issue that the chart creation context
was not dependant on which figure was edited.

Task: 4282798
@robodoo
Copy link
Collaborator

robodoo commented Nov 25, 2024

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants