WIP #5407
Open
WIP #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
laa-odoo
force-pushed
the
master-formula-add-switch-function-laa
branch
from
e0c1b12 to
5314a0c
Compare
anhe-odoo
requested changes
Jan 6, 2025
src/functions/arguments.ts
Outdated
| functionDescription: FunctionDescription, | ||
| nbrArgSupplied: number | ||
| ): (argPosition: number) => number | undefined { | ||
| if (nbrArgSupplied === functionDescription.minArgRequired) { |
There was a problem hiding this comment.
Wont work if we have something like [required, optional, required]
laa-odoo
force-pushed
the
master-formula-add-switch-function-laa
branch
2 times, most recently
from
eaada6a to
9688517
Compare
laa-odoo
force-pushed
the
master-formula-add-switch-function-laa
branch
from
9688517 to
c30f4be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 3829128