Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] spreadsheet: avoid parasitic renders #5412

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 6, 2025

Description

Clicking on a button on the topbar would trigger 3 renders:

  • one on model update (expected)
  • one because we received a collaborative event for our own revision (useless)
  • one because the onClick of the topbar calls DOMFocusableElementStore.focus, which triggers a render because a store method was called (useless)

Task: 4373054

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5346

Clicking on a button on the topbar would trigger 3 renders:
- one on model update (expected)
- one because we received a collaborative event for our own revision
(useless)
- one because the onClick of the topbar calls
`DOMFocusableElementStore.focus`, which triggers a render because a
store method was called (useless)

Task: 4373054
X-original-commit: 30e1e37
@robodoo
Copy link
Collaborator

robodoo commented Jan 6, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 6, 2025

@hokolomopo @rrahir cherrypicking of pull request #5346 failed.

stdout:

Auto-merging src/collaborative/session.ts
Auto-merging src/components/bottom_bar/bottom_bar_sheet/bottom_bar_sheet.ts
Auto-merging src/components/composer/grid_composer/grid_composer.ts
CONFLICT (content): Merge conflict in src/components/composer/grid_composer/grid_composer.ts
Auto-merging src/components/grid/grid.ts
Auto-merging tests/bottom_bar/bottom_bar_component.test.ts
Auto-merging tests/top_bar_component.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants