Fix windows console colours bug

odygrd · Aug 15, 2020 · 914a761 · 914a761
1 parent 63a5aa7
commit 914a761
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/quill/include/quill/handlers/ConsoleHandler.h b/quill/include/quill/handlers/ConsoleHandler.h
@@ -42,7 +42,12 @@ class ConsoleColours
   void set_colour(LogLevel log_level, WORD colour) noexcept;
 
   /**
-   * @return True if we have enabled colours
+   * @return true if we are in terminal and have also enabled colours
+   */
+  QUILL_NODISCARD bool can_use_colours() const noexcept;
+
+  /**
+   * @return true if we have setup colours
    */
   QUILL_NODISCARD bool using_colours() const noexcept;
 

diff --git a/quill/src/handlers/ConsoleHandler.cpp b/quill/src/handlers/ConsoleHandler.cpp
@@ -63,7 +63,10 @@ void ConsoleColours::set_colour(LogLevel log_level, WORD colour) noexcept
 }
 
 /***/
-bool ConsoleColours::using_colours() const noexcept { return _can_use_colours && _using_colours; }
+bool ConsoleColours::can_use_colours() const noexcept { return _can_use_colours && _using_colours; }
+
+/***/
+bool ConsoleColours::using_colours() const noexcept { return _using_colours; }
 
 /***/
 WORD ConsoleColours::colour_code(LogLevel log_level) const noexcept