Exclude external_id from resources serializers (#1701)

* fixes #1687; exclude `external_id` from resources serializers * fix typo
ohcnetwork · Nov 8, 2023 · 942cfe5 · 942cfe5
1 parent 1a232d7
commit 942cfe5
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/care/facility/api/serializers/resources.py b/care/facility/api/serializers/resources.py
@@ -174,8 +174,8 @@ def create(self, validated_data):
 
     class Meta:
         model = ResourceRequest
-        exclude = ("deleted",)
-        read_only_fields = TIMESTAMP_FIELDS + ("external_id",)
+        exclude = ("deleted", "external_id")
+        read_only_fields = TIMESTAMP_FIELDS
 
 
 class ResourceRequestCommentSerializer(serializers.ModelSerializer):
@@ -195,9 +195,5 @@ def create(self, validated_data):
 
     class Meta:
         model = ResourceRequestComment
-        exclude = ("deleted", "request")
-        read_only_fields = TIMESTAMP_FIELDS + (
-            "created_by",
-            "external_id",
-            "id",
-        )
+        exclude = ("deleted", "request", "external_id")
+        read_only_fields = TIMESTAMP_FIELDS + ("created_by",)