Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Response Includes Redundant external_id #1687

Closed
konavivekramakrishna opened this issue Oct 26, 2023 · 0 comments · Fixed by #1701
Closed

Request Response Includes Redundant external_id #1687

konavivekramakrishna opened this issue Oct 26, 2023 · 0 comments · Fixed by #1701

Comments

@konavivekramakrishna
Copy link
Contributor

Describe the bug
In the response body of GET requests (comments), there is an extra duplicate attribute "external_id" being sent, which is the same as the "id" in the response.

image
image

To Reproduce
Steps to reproduce the behavior:
1.Go to https://care.ohc.network/resource/df18360c-5cb8-446b-b981-9452beafce14
2.In the network tab, check the response, and you will find "external_id" is included, which is identical to "id."

Expected behaviour
1.Remove the "external_id" from the response body.
@konavivekramakrishna konavivekramakrishna changed the title Remove external_id in response body Request Response Includes Redundant 'external_id Oct 26, 2023
@konavivekramakrishna konavivekramakrishna changed the title Request Response Includes Redundant 'external_id Request Response Includes Redundant external_id Oct 26, 2023
rithviknishad added a commit that referenced this issue Nov 7, 2023
@rithviknishad
fixes #1687; exclude external_id from resources serializers
b795b14
@rithviknishad rithviknishad mentioned this issue Nov 7, 2023
Merged
4 tasks
vigneshhari pushed a commit that referenced this issue Nov 8, 2023
@rithviknishad
Exclude external_id from resources serializers (#1701)
942cfe5 
* fixes #1687; exclude `external_id` from resources serializers

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude external_id from resources serializers ohcnetwork/care
1 participant
@konavivekramakrishna