Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds doctor and staff fields in location model #1264

Closed
wants to merge 3 commits into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Apr 22, 2023

Feature Request

Proposed Changes

  • Adds duty_staff field to asset location model and serializer
  • Adds home_facility type filter in UserFilter

Associated PR

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@coronasafe/code-reviewers

@aeswibon aeswibon marked this pull request as ready for review April 22, 2023 17:49
@aeswibon aeswibon requested a review from a team as a code owner April 22, 2023 17:49
@aeswibon aeswibon added the P2 label Apr 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0daef7f) 60.02% compared to head (6a693e0) 60.05%.

❗ Current head 6a693e0 differs from pull request most recent head 8b9d4d1. Consider uploading reports for the commit 8b9d4d1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   60.02%   60.05%   +0.02%     
==========================================
  Files         208      208              
  Lines       11319    11322       +3     
  Branches     1606     1606              
==========================================
+ Hits         6794     6799       +5     
+ Misses       4301     4300       -1     
+ Partials      224      223       -1     
Files Coverage Δ
care/facility/api/serializers/asset.py 84.39% <100.00%> (+0.09%) ⬆️
care/facility/api/viewsets/facility_users.py 93.75% <100.00%> (+0.20%) ⬆️
care/facility/models/asset.py 95.28% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

nihal467 commented Oct 3, 2023

LGTM

sainak
sainak previously requested changes Oct 4, 2023
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation required for limiting the number of staff assigned

@vigneshhari
Copy link
Member

I don't really see a use for this. how are users going to be added in the M2M model?

@nihal467
Copy link
Member

@gigincg can you comment on this ?

@gigincg
Copy link
Member

gigincg commented Oct 20, 2023

@cp-coder @sainak Rephrasing @vigneshhari 's comment. I don't see CRUD APIs for duty_doctors

@aeswibon
Copy link
Member Author

Discussed in the EOD. Closing the PR as I will be creating a new endpoint that will do the same functionality

@aeswibon aeswibon closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants