-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds doctor and staff fields in location model #1264
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
a8a5de1
to
042536d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
==========================================
+ Coverage 60.02% 60.05% +0.02%
==========================================
Files 208 208
Lines 11319 11322 +3
Branches 1606 1606
==========================================
+ Hits 6794 6799 +5
+ Misses 4301 4300 -1
+ Partials 224 223 -1
☔ View full report in Codecov by Sentry. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation required for limiting the number of staff assigned
I don't really see a use for this. how are users going to be added in the M2M model? |
@gigincg can you comment on this ? |
@cp-coder @sainak Rephrasing @vigneshhari 's comment. I don't see CRUD APIs for duty_doctors |
Discussed in the EOD. Closing the PR as I will be creating a new endpoint that will do the same functionality |
Feature Request
Proposed Changes
duty_staff
field toasset location
model and serializerhome_facility
type filter inUserFilter
Associated PR
Merge Checklist
/docs
@coronasafe/code-reviewers