fix: tests for ambulance APIs #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeswibon
force-pushed
the
issue#1379
branch
from
9b65315 to
8eff39a
Compare
aeswibon
force-pushed
the
issue#1379
branch
from
125e63c to
b8fbb3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1575 +/- ##
==========================================
+ Coverage 60.62% 60.96% +0.34%
==========================================
Files 210 210
Lines 11484 11486 +2
Branches 1633 1633
==========================================
+ Hits 6962 7003 +41
+ Misses 4284 4242 -42
- Partials 238 241 +3 ☔ View full report in Codecov by Sentry. |
sainak
approved these changes
Nov 3, 2023
sainak
reviewed
Nov 3, 2023
| return ambulance | ||
|
|
||
|
|
||
| class DeleteDriverSerializer(serializers.Serializer): | ||
| driver_id = serializers.IntegerField() | ||
| driver_id = serializers.UUIDField() |
There was a problem hiding this comment.
note: this endpoint is not being used on the frontend so it is okay to change to ext id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Proposed Changes
Associated Issue
ambulancemodule #1379Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins