ICD-11 diagnosis cannot be both provisional and final

care/facility/api/serializers/patient_consultation.py

@@ -443,6 +443,15 @@ def validate(self, attrs):
                         }
                     )
 
+        if len(set(final_diagnosis).intersection(provisional_diagnosis)):
+            raise ValidationError(
+                {
+                    "icd11_diagnoses": [
+                        "A diagnosis cannot be both provisional and final"
+                    ],
+                }
+            )
+
         if (
             "icd11_principal_diagnosis" in validated
             and validated.get("suggestion") != SuggestionChoices.DD

care/facility/tests/test_patient_consultation_api.py

@@ -8,6 +8,7 @@
     CATEGORY_CHOICES,
     PatientConsultation,
 )
+from care.facility.static_data.icd11 import ICDDiseases, fetch_from_db
 from care.utils.tests.test_utils import TestUtils
 
 
@@ -257,6 +258,25 @@ def test_referred_to_external_valid_value(self):
         )
         self.assertEqual(res.status_code, status.HTTP_200_OK)
 
+    def test_icd11_diagnosis_final_and_provisional(self):
+        ICDDiseases.insert_many(fetch_from_db())
+        consultation = self.create_admission_consultation(
+            suggestion="A",
+            admission_date=make_aware(datetime.datetime(2023, 4, 1, 15, 30, 00)),
+        )
+        res = self.update_consultation(
+            consultation,
+            icd11_provisional_diagnoses=["1665365733"],
+            icd11_diagnoses=["1665365733"],
+        )
+        self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)
+        res = self.update_consultation(
+            consultation,
+            icd11_provisional_diagnoses=["1665365733"],
+            icd11_diagnoses=["588616678"],
+        )
+        self.assertEqual(res.status_code, status.HTTP_200_OK)
+
     def test_medico_legal_case(self):
         consultation = self.create_admission_consultation(
             medico_legal_case=True,