Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds authz for Prescription & Medicine Administrations #1704

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Add ConsultationRelatedPermissionMixin to Prescription and MedicineAdministration model

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (553b2a5) 61.66% compared to head (2d76432) 61.66%.
Report is 11 commits behind head on master.

Files Patch % Lines
care/abdm/api/viewsets/health_facility.py 10.00% 9 Missing ⚠️
care/abdm/api/viewsets/healthid.py 33.33% 4 Missing ⚠️
care/abdm/api/viewsets/auth.py 40.00% 3 Missing ⚠️
care/facility/models/prescription.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1704   +/-   ##
=======================================
  Coverage   61.66%   61.66%           
=======================================
  Files         212      211    -1     
  Lines       11691    11725   +34     
  Branches     1658     1663    +5     
=======================================
+ Hits         7209     7230   +21     
- Misses       4184     4197   +13     
  Partials      298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rithviknishad rithviknishad marked this pull request as ready for review November 14, 2023 07:49
@sainak sainak requested a review from Ashesh3 December 6, 2023 12:22
@vigneshhari
Copy link
Member

@sainak
Copy link
Member

sainak commented Dec 7, 2023

#1704 (files) AuthZ is already present

The change is for adding for write authz

@vigneshhari
Copy link
Member

Writes already had AuthZ as well.

@vigneshhari vigneshhari merged commit bf7ff29 into master Mar 4, 2024
11 checks passed
@vigneshhari vigneshhari deleted the prescription-authz branch March 4, 2024 13:16
Ashesh3 pushed a commit that referenced this pull request Mar 5, 2024
* Adds authz for Prescription & MAR
fixes #1695

* adds missing `DRYPermissions` in viewsets

* fix missing object write permission

---------

Co-authored-by: Vignesh Hari <[email protected]>
Co-authored-by: Aakash Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authz missing for Prescriptions viewset
3 participants