Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes check for no treating physician and not mandate for Domicialiary Care #2382

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 21, 2024

Proposed Changes

  • Fixes issue with how None treating physician was checked for throwing required validation error
  • Skip treating physician being required for Domicialiary Care patients

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@rithviknishad rithviknishad requested a review from a team as a code owner August 21, 2024 10:50
Copy link

sentry-io bot commented Aug 21, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: care/facility/api/serializers/patient_consultation.py

Function Unhandled Issue
validate AttributeError: 'NoneType' object has no attribute 'user_type' /api/v1...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (a4e2f8b) to head (96e8417).

Files Patch % Lines
...e/facility/api/serializers/patient_consultation.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2382      +/-   ##
===========================================
+ Coverage    63.86%   63.88%   +0.01%     
===========================================
  Files          239      239              
  Lines        13439    13440       +1     
  Branches      1914     1914              
===========================================
+ Hits          8583     8586       +3     
+ Misses        4508     4507       -1     
+ Partials       348      347       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 requested review from vigneshhari and sainak August 22, 2024 09:19
@vigneshhari vigneshhari merged commit b8172f1 into develop Aug 24, 2024
4 checks passed
@vigneshhari vigneshhari deleted the rithviknishad/fix/treating-physician-not-required-for-dc-and-dd branch August 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'user_type'
5 participants