Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Add a better search UI for patients index page #8691 #8834

Merged
merged 87 commits into from
Dec 5, 2024
Merged

Fixed Add a better search UI for patients index page #8691 #8834

merged 87 commits into from
Dec 5, 2024

Conversation

i0am0arunava
Copy link
Contributor

@i0am0arunava i0am0arunava commented Oct 20, 2024 •
edited by coderabbitai bot
Loading

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a SearchByMultipleFields component for enhanced search functionality across various fields.
    • Added a customizable dialog interface using Radix UI components.
    • Implemented a command interface with multiple components for improved user interaction.
    • Enhanced phone number input with better error handling and help text visibility.
    • Added new components for popover and scroll area functionalities.

  • Bug Fixes

    • Updated selectors for patient and facility search inputs to ensure correct functionality.

  • Improvements

    • Streamlined the layout and organization of the ManagePatients and FacilityList components.
    • Enhanced localization support for search functionalities.
    • Improved search input handling and added a debounce mechanism for performance.

  • Chores

    • Updated dependencies in package.json for improved functionality and performance.

@i0am0arunava i0am0arunava requested a review from a team as a code owner October 20, 2024 05:39
@netlify Netlify
Copy link

netlify bot commented Oct 20, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1507227
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/675185b1c27a9e0009d595c4
😎 Deploy Preview https://deploy-preview-8834--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@i0am0arunava i0am0arunava mentioned this pull request Oct 20, 2024
Closed
rithviknishad
rithviknishad requested changes Oct 20, 2024
View reviewed changes
src/Components/Form/FormFields/FormField.tsx Outdated Show resolved Hide resolved
src/Components/Form/FormFields/PhoneNumberFormField.tsx Outdated Show resolved Hide resolved
src/Components/Common/SearchByMultipleFields.tsx Outdated Show resolved Hide resolved
bodhish
bodhish requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test it out as I am sure we haven't captured all edge cases here

src/Components/Form/FormFields/FormField.tsx Outdated Show resolved Hide resolved
src/Components/Common/SearchByMultipleFields.tsx Outdated Show resolved Hide resolved
src/Components/Common/SearchByMultipleFields.tsx Outdated
inputClassName,
]);

return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component should have a default state where it says a simple help text. EG
image

@bodhish
Copy link
Member

bodhish commented Oct 21, 2024 •
edited
Loading

@nihal467 do test it

Also @i0am0arunava please add a good title for the PR

@i0am0arunava i0am0arunava changed the title Issues/8691 add better serchui Fixed Add a better search UI for patients index page #8691 Oct 21, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 21, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @i0am0arunava,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@vinutv
Copy link
Member

vinutv commented Oct 21, 2024

Screenshot 2024-10-21 at 2 15 39 PM

It's great that shortcut keys are available to access the search type from the dropdown. The dropdown should also be navigable using the up and down arrow keys on the keyboard.

@vinutv
Copy link
Member

vinutv commented Oct 21, 2024

Screenshot 2024-10-21 at 2 19 30 PM

The error message is hidden under the search buttons.

@vinutv
Copy link
Member

vinutv commented Oct 21, 2024

Screenshot 2024-10-21 at 2 25 25 PM

Typed "/" and selected "Phone Number," but the phone number field didn't get focused. It should focus on the phone number input to make it typable when the search type is selected. However, the focus remains on the search button.

@nihal467
Copy link
Member

nihal467 commented Oct 21, 2024 •
edited
Loading

@i0am0arunava can you fix the lint, resolve conflicts, and make the requested changes to get it ready for review

@i0am0arunava
Copy link
Contributor Author

@i0am0arunava can you fix the lint, resolve conflicts, and make the requested changes to get it ready for review

Yes, give me some time,

@i0am0arunava
Copy link
Contributor Author

@i0am0arunava can you fix the lint, resolve conflicts, and make the requested changes to get it ready for review

done

@i0am0arunava
Copy link
Contributor Author

@rithviknishad,@bodhish ,@nihal467, I have made changes and raised pr please review .

@bodhish
Copy link
Member

bodhish commented Oct 22, 2024

I don't see any of the changes Vinu requested implemented!

@bodhish
Copy link
Member

bodhish commented Oct 22, 2024

Also did you break the mobile input its showing IN instead of the country logo 🤔

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi, @i0am0arunava,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Dec 4, 2024

@shivankacker can you clear the merge conflict

@shivankacker shivankacker removed the merge conflict pull requests with merge conflict label Dec 4, 2024
@nihal467
Copy link
Member

nihal467 commented Dec 4, 2024 •
edited
Loading

LGTM @khavinshankar @rithviknishad lets get it reviewed ASAP

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

👋 Hi, @i0am0arunava,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 5, 2024
@bodhish bodhish merged commit a24b9ca into ohcnetwork:develop Dec 5, 2024
13 of 16 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

@shivankacker @i0am0arunava Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

This was referenced Dec 5, 2024
Merged
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 18, 2024
Closed
Merged
Closed
Closed
Closed
This was referenced Dec 27, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rithviknishad rithviknishad rithviknishad approved these changes

@shivankacker shivankacker Awaiting requested review from shivankacker

@sainak sainak Awaiting requested review from sainak

@bodhish bodhish Awaiting requested review from bodhish

@nihal467 nihal467 Awaiting requested review from nihal467

Assignees

@shivankacker shivankacker

Labels
merge conflict pull requests with merge conflict needs review tested
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a better search UI for patients index page
8 participants
@i0am0arunava @bodhish @vinutv @nihal467 @shivankacker @rithviknishad @sainak @gigincg