-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Referral letter preview desktop #8954
Referral letter preview desktop #8954
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ui/separator.tsx. to resolve deploy issue
@bodhish should i update anything? |
@rithviknishad can you check |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/components/Shifting/ShiftDetails.tsx (1)
299-303
: Consider responsive QR code sizingThe QR code has a fixed size of 120px which might not scale well on smaller screens.
Consider making the QR code size responsive:
-size={120} +size={window.innerWidth < 640 ? 80 : 120} +className="mt-4 sm:mt-0 max-w-full"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
src/components/Shifting/ShiftDetails.tsx
(3 hunks)
🧰 Additional context used
📓 Learnings (1)
src/components/Shifting/ShiftDetails.tsx (1)
Learnt from: modamaan
PR: ohcnetwork/care_fe#8954
File: src/components/Shifting/ShiftDetails.tsx:432-433
Timestamp: 2024-11-12T10:23:10.322Z
Learning: In `src/components/Shifting/ShiftDetails.tsx`, the `print` button is inside the `PrintPreview` component and the `close` button is outside, so aligning them with flexbox within the same container isn't feasible.
🔇 Additional comments (4)
src/components/Shifting/ShiftDetails.tsx (4)
10-12
: LGTM! Clean import additions
The new imports for PrintPreview and Card components are properly organized and correctly sourced from their respective paths.
279-437
: Well-structured print preview implementation
The print preview implementation is well-organized with:
- Semantic HTML structure using Card components
- Consistent use of translation functions
- Clear visual hierarchy
- Proper spacing and typography
448-448
: LGTM! Clean print mode implementation
The print mode toggle is implemented correctly with proper conditional rendering.
372-374
:
Add null check for consultation date
The date formatting could throw an error if the consultation object is undefined.
Apply this diff to add a null check:
-{formatDateTime(
- consultation.encounter_date || consultation.created_date,
-) || "-"}
+{consultation
+ ? formatDateTime(
+ consultation.encounter_date || consultation.created_date
+ )
+ : "-"}
Likely invalid or redundant comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rithviknishad what change should I make, please ? |
@modamaan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
Referral letter preview desktop and responsive
Before
After
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
Release Notes
New Features
Improvements
User Interface