-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimenting with Microfrontends #9194
Changes from 25 commits
1637e00
2918119
c910111
4497313
b0b0880
4ebd325
92f24fd
4d5fae7
20754eb
94c8217
efbf43c
ca3e118
9b982c1
dbc9443
cba055f
2bf352e
dd1cdf9
5900873
29ba23c
d94bd4d
ae364be
79e2910
a9b39f2
e1b0608
6279488
a52cdc0
c601ae5
34858e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,11 +7,11 @@ REACT_APP_COVER_IMAGE_ALT=https://cdn.ohc.network/care_logo.svg | |
REACT_PUBLIC_URL=https://care.ohc.network | ||
|
||
# Care API URL without the /api prefix | ||
REACT_CARE_API_URL=https://careapi.ohc.network | ||
REACT_CARE_API_URL=https://care-api.do.ohc.network | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Update Vercel configuration to match the new API endpoint The API endpoint change in
{
"source": "/api/(.*)",
"destination": "https://care-api.do.ohc.network/api/$1"
} 🔗 Analysis chainVerify the API endpoint change impact The API endpoint change from careapi.ohc.network to care-api.do.ohc.network could affect all API calls in the application. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for any hardcoded references to the old API URL
rg -i "careapi\.ohc\.network"
# Check for any API URL references in configuration files
fd -e json -e yaml -e yml -e config | xargs rg -i "careapi\.ohc\.network"
Length of output: 325 Script: #!/bin/bash
# Check for any references to the new API URL to ensure it's not already in use elsewhere
rg -i "care-api\.do\.ohc\.network"
# Check the vercel.json file content to understand the rewrite rules
cat vercel.json
# Look for any environment configuration related files
fd -e env -e env.example -e env.sample
Length of output: 291 |
||
|
||
# Dev envs | ||
ESLINT_NO_DEV_ERRORS=true | ||
CARE_CDN_URL="https://egov-s3-facility-10bedicu.s3.amazonaws.com https://egov-s3-patient-data-10bedicu.s3.amazonaws.com http://localhost:4566" | ||
REACT_ALLOWED_LOCALES="en,hi,ta,ml,mr,kn" | ||
|
||
REACT_ENABLED_APPS="" | ||
REACT_ENABLED_APPS="ohcnetwork/care_livekit_fe@main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
API documentation needs type safety improvements
The API route definition example could be enhanced:
Type<ScribeModel>()
syntax seems non-standardroutes
object structureConsider updating to: