Issues/#7255/utilizing higher order form in update shifting form

[Utkarsh-Anandani]

Proposed Changes

• Fixes Implement 'Discard Changes' Modal for Form Editing Confirmation #7255
• used DraftSection
• used useAutoSaveReducer

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Introduced a draft section for enhanced state management
  • Implemented a custom auto-save reducer for improved state handling

• Bug Fixes

  • Updated error handling mechanism with more precise error dispatching

• Refactor

  • Improved state management logic in the Shift Details Update component

[coderabbitai]

Walkthrough

The pull request modifies the ShiftDetailsUpdate component in the shifting module, introducing a custom useAutoSaveReducer to enhance state management. The changes include updating the reducer's action types, adding a new DraftSection component, and refining error handling logic. The modifications aim to improve form state management and provide more flexible state update mechanisms.

Changes

File	Change Summary
src/components/Shifting/ShiftDetailsUpdate.tsx	- Replaced useReducer with custom useAutoSaveReducer - Updated reducer action types (renamed "set_error" to "set_errors") - Added new "set_state" action type - Imported and integrated DraftSection component - Modified validateForm function

Assessment against linked issues

Objective	Addressed	Explanation
Implement 'Discard Changes' Modal [#7255]	❓	Partial implementation - draft support added, but full modal confirmation not evident
Refactor form to use higher-order <Form> component	❓	Changes suggest movement in this direction, but full refactoring not complete

Possibly related PRs

• phone size responsive issue shifting details page #8831 Open #9256: Modifications to ShiftDetails component with potential state management similarities
• fix: DateInput and Actions button not optimised for mobile viewports  #9432: Mobile optimization that could complement UX improvements
• User creation form bug fix #9404: Form handling and validation logic changes

Suggested labels

tested, needs review, P1

Suggested reviewers

• nihal467
• rithviknishad

Poem

🐰 In the realm of shifts and state,
A rabbit's code begins to create
Reducer magic, drafts so neat
Saving changes, making data complete
With auto-save, our form's now great! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94585fd and f81c93a.

📒 Files selected for processing (1)

• src/components/Shifting/ShiftDetailsUpdate.tsx (5 hunks)

🔇 Additional comments (6)

src/components/Shifting/ShiftDetailsUpdate.tsx (6)

3-3: No issues with the addition of useState.
It is standard practice to use useState in tandem with more sophisticated hooks (like useAutoSaveReducer) for managing UI-related state.

---

41-41: Clean import of DraftSection and useAutoSaveReducer.
Importing these in one statement is organized; however, ensure that no cyclical dependencies occur if these components scale in complexity in the future.

---

104-104: Renaming the action to set_errors is more descriptive.
This better conveys that multiple errors may be stored. Good job on improving clarity.

---

110-113: Return early from "set_state" only if action.state exists.
This pattern is acceptable. Just be mindful that returning the entire action.state could inadvertently overwrite other parts of the reducer’s state if it doesn’t match the shape exactly.

---

117-120: Excellent usage of useAutoSaveReducer.
This approach will help unify autosaving and provide a more streamlined dev experience. Please ensure autosaving is idempotent and properly handles any pending changes, especially if the user navigates away before the save completes.

---

339-344: <DraftSection> integration is well-placed.
The implementation suggests a clear workflow for retrieving and applying saved drafts. Verify that the newState always has the correct shape; otherwise, you could lose partial data or run into type mismatches.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	f81c93a
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67712fa282673000080a8463
😎 Deploy Preview	https://deploy-preview-9605--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[rithviknishad]

This file is no longer present in the rearchitecture