Fix: Forgot password error should be handled properly

[abhimanyurajeesh]

Proposed Changes

• Fixes Forgot password error should be handled properly #9686
• Major Change: In the onSuccess function of your forgotPasswordMutation, I added a condition to check if the response from the server indicates a successful operation. This is done by checking if response.res exists and if response.res.ok is true, which means the HTTP response status is in the successful range (typically 200-299).

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Screenshot

Summary by CodeRabbit

• Bug Fixes
  • Enhanced user feedback during login and password reset processes with toast notifications.
  • Simplified loading state for the forgot password functionality.

[coderabbitai]

Walkthrough

The pull request refactors the forgotPasswordMutation logic in the Login component located in src/components/Auth/Login.tsx. It simplifies the mutation call by using the mutate function from the useMutation hook and updates the success notification mechanism to utilize the toast library. The error handling is revised to remove direct error state management, relying instead on toast notifications for user feedback. Additionally, the loading state logic has been simplified by eliminating unnecessary checks.

Changes

File	Change Summary
src/components/Auth/Login.tsx	Refactored forgotPasswordMutation logic; updated success and error handling using toast notifications; simplified loading state calculation.

Assessment against linked issues

Objective	Addressed	Explanation
Handle forgot password errors properly [#9686]	❌	The current implementation relies solely on toast notifications without specific error handling for failed requests.
Prevent simultaneous success and failure messages	✅

Possibly related PRs

• Fixed: No notification shown when invalid OTP is entered #9667: This PR modifies the error handling logic for OTP verification in the Login component, which is directly related to the changes made in the main PR that also involves the Login component and its mutation logic.
• Toast Notifications: Handle pydantic spec errors #9706: This PR enhances error handling in the errorHandler.ts file, which is relevant because the main PR updates the error handling in the Login component to utilize toast notifications, indicating a connection in how errors are managed across the application.

Suggested labels

good to merge, tested, P1

Suggested reviewers

• rithviknishad
• Jacobjeevan

Poem

🐰 In the land of logs and codes so bright,
A rabbit hops with joy and delight.
With toasty messages, clear and true,
No more errors in a tangled queue.
Forgot password, a breeze to embrace,
Hopping forward, we quicken the pace! 🔐

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 292758e and 3f03b58.

📒 Files selected for processing (1)

• src/components/Auth/Login.tsx (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/components/Auth/Login.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	3f03b58
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67781342aa0cb90008fc3b3d
😎 Deploy Preview	https://deploy-preview-9707--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[abhimanyurajeesh]

@rithviknishad requesting to review, Thank you!

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Auth/Login.tsx (1)

108-109: Consider leveraging optional chaining for clarity.

You can simplify the condition by using optional chaining on response.res?.ok instead of checking response.res first.

- if (response.res && response.res.ok) {
+ if (response.res?.ok) {

🧰 Tools

🪛 Biome (1.9.4)

[error] 109-109: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d6ae92 and 292758e.

📒 Files selected for processing (1)

• src/components/Auth/Login.tsx (1 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

src/components/Auth/Login.tsx

[error] 109-109: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

🔇 Additional comments (2)

src/components/Auth/Login.tsx (2)

110-113: Success notification handling looks good.

Deferring to Notification.Success with an i18n message is a neat way to ensure a uniform user experience.

---

116-118: Error notification handling is well-structured.

This approach gracefully displays a localized message when the password reset fails, improving user feedback.

[rithviknishad]

Although this works, we are moving towards migrating to useQuery/useMutation from tanstack query.

See docs: https://docs.ohc.network/docs/care/development/data-fetching-in-care/

Do make changes as mentioned in the docs.

It should automatically handle the notifications for you (for http errors). Success would still need to be manually handled though.

[abhimanyurajeesh]

Although this works, we are moving towards migrating to useQuery/useMutation from tanstack query.

See docs: https://docs.ohc.network/docs/care/development/data-fetching-in-care/

Do make changes as mentioned in the docs.

It should automatically handle the notifications for you (for http errors). Success would still need to be manually handled though.

okay @rithviknishad on it

[github-actions]

@abhimanyurajeesh Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌