Issues/#9762/overlap texts

[cbum-dev]

Proposed Changes

• Fixes Overlapping text on mobile #9762

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• UI/UX Improvements

  • Enhanced appointment filtering and display components
  • Improved responsiveness of search and filter elements
  • Updated layout to allow full-width input and scrollable tabs
  • Refined slot selection interaction for better user experience

• Responsive Design

  • Added responsive grid layout for facility user role component
  • Adjusted component styling for better screen adaptability

[coderabbitai]

Walkthrough

The pull request introduces responsive design improvements in two components: AppointmentsPage.tsx and EditFacilityUserRoleSheet.tsx. In the appointments page, the changes focus on enhancing layout flexibility by modifying input and tab component widths. The facility user role sheet component receives a responsive grid layout adjustment, ensuring better display across different screen sizes. These modifications aim to address potential mobile display issues and improve overall user interface adaptability.

Changes

File	Change Summary
src/components/Schedule/Appointments/AppointmentsPage.tsx	- Input component width changed to w-full - Added w-full overflow-scroll to Tabs component - Updated SlotFilter component selection handling
src/pages/FacilityOrganization/components/EditFacilityUserRoleSheet.tsx	- Modified div class to sm:grid grid-cols-2 gap-4 pt-2 border-t for responsive grid layout

Assessment against linked issues

Objective	Addressed	Explanation
Resolve overlapping text on mobile [#9762]	✅

Possibly related PRs

• [Enhancements to the nursing care procedures and routines tables #9079] Enhancements to nursing care procedures and routines tables
• [Adds support for searching for OrganizationSelector and fix scroll for dropdown in sheet #9620] Adds support for searching OrganizationSelector and fix scroll for dropdown
• [ Horizontal scroll bar used #9692] Horizontal scroll bar implementation

Suggested labels

needs review, needs testing

Suggested reviewers

• rithviknishad
• Jacobjeevan

Poem

🐰 Responsive rabbit hops with glee,
Pixels dancing, layout now free!
Mobile screens no longer tight,
Components flex with pure delight,
Code that bounces, smooth and neat! 🌈

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	a005378
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/677a99ce2408ab00084636a9
😎 Deploy Preview	https://deploy-preview-9765--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Schedule/Appointments/AppointmentsPage.tsx (1)

481-481: Consider switching to overflow-x-auto for better control of scroll behavior.
overflow-scroll always shows scrollbars on some platforms, which can be visually unappealing if the content doesn't require scrolling. Switching to overflow-x-auto or overflow-auto can result in a cleaner UI.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6f4ab6 and a3d7649.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

• src/components/Schedule/Appointments/AppointmentsPage.tsx (2 hunks)
• src/pages/FacilityOrganization/components/EditFacilityUserRoleSheet.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/pages/FacilityOrganization/components/EditFacilityUserRoleSheet.tsx

🔇 Additional comments (1)

src/components/Schedule/Appointments/AppointmentsPage.tsx (1)

259-259: Use of className="w-full" for the search field is a solid approach.
This effectively ensures that the input stretches to match its container width, improving responsiveness where horizontal space might be tight.

[rithviknishad]

different solution was already suggested in the issue

[cbum-dev]

different solution was already suggested in the issue

My bad, I thought another solution. Working on your proposed solution now.