Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #241
Before ohkami provided
typed::{Query, Payload}
for handling query parameters and payloads likebut this enforces integrating format and schema, which is not modular or healthy.
For example, think about a case of maintaining a handler that takes a
Hello<'_>
as argument, and oneday you have to change the payload format fromjson
intox-www-form-urlemcoded
. In this situation with current Ohkami, you have to changeinto
this means you need to touch the struct definition, while the schema of payload is not changed.
Additionally, the handler definition
doesn't show clearly how it takes the data of type
Hello<'_>
( and you have to go to the definition ofHello
to know it ).Now I think the responsibility of format ( query, json, urlencoded, ... ) should not owe to a struct in charge of the schema.
This PR removes
typed::{Payload, Query}
and introducesformat
module to separate schema from format: