refactor(sse): DataStream
: more intuitive colocation and interface
#298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataStream
, the core type for streaming response, before lived intyped
module unintuitively, and its interface is so too due to some confusion around the type of stream item (T
v.s.Result<T>
) and the conversion (Into<String>
).This PR migrates it into
sse::{DataStream, Data}
:DataStream
in new module namedsse
. This is intuitive.T
items.Data
trait instead ofInto<String>
for data conversion. This makes the context clear.In addition, this PR eliminates a double-boxing of previous SSE implementation.