Improve report panel large cells handling #698
Conversation
| {value.length > 50 ? ( | ||
| <LightTooltip title={value}> | ||
| <div className="cell-content" style={{ lineClamp: 1 }}> | ||
| {truncate(value, { length: 50 })} |
There was a problem hiding this comment.
it looks great @roll but I think it should be when it's less than 50. This is how i see tables, there is the ellipsis after around 17 characters. I would expect the tootltip to be visible for anything that is shorteded by the ellipsis. maybe is there a way of detecting how much of the text is visible? what do you think @romicolman ?
There was a problem hiding this comment.
Yea, we can reduce the visible size
There was a problem hiding this comment.
Hi! Sorry for the late response on this ticket. The example file is in the ticket, here.
I have just checked the implementation. I'm adding a video to show how the tooltip looks like on the errors report panel. We have a lot of blank space on the sidebar when content is large. I don't know if we can improve that. If that's not possible or if there is not other solution, please, let's implement.
Grabacion.de.pantalla.2024-12-23.a.la.s.10.12.16.a.m.mov
@guergana regarding your comment. We are checking tooltip on the errors report panel, but your screenshot if from the datagrid. Can you calarify? Thanks
Deploying opendataeditor with
|
| Latest commit: |
dad8a66
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59e8577a.opendataeditor.pages.dev |
| Branch Preview URL: | https://652-fix-report-large-cells.opendataeditor.pages.dev |
|
@romicolman |
Ah, my bad, @romicolman yes, my comment was about the datagrid. |
One of the options to make it easily consumable. BTW can you please share the file from the issue @romicolman?