Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: settings window #1278

Merged
merged 36 commits into from
Dec 30, 2024
Merged

feat: settings window #1278

merged 36 commits into from
Dec 30, 2024

Conversation

oliverschwendener
Copy link
Owner

@oliverschwendener oliverschwendener commented Dec 3, 2024

The goal of this PR is to solve #1119 and have a separate window for the settings.

image

Open tasks:

  • Add ability to open settings from tray icon context menu
  • Add ability to open settings from ueli extension search results
  • Add ability to open settings from keyboard shortcut
  • Add ability to open settings from "browse extensions"
  • Prevent hiding of search window on blur when settings window is open and focused
  • Add correct window icon
  • Fix bug that prevents the theme from being reactive
  • Fix bug that prevents labels to be updated in settings window when language is changed
  • Reduce memory usage by making sure settings window is destroyed when not used
  • Extract common window management behavior to separate module
  • Test app in dev mode on:
    • Windows
    • macOS
    • Linux
  • Test packaged app on:
    • Windows
    • macOS
    • Linux

@oliverschwendener oliverschwendener self-assigned this Dec 3, 2024
@oliverschwendener oliverschwendener marked this pull request as ready for review December 30, 2024 13:49
@oliverschwendener oliverschwendener merged commit 08ee309 into main Dec 30, 2024
3 checks passed
@oliverschwendener oliverschwendener deleted the feat-settings-window branch December 30, 2024 13:52
Copy link
Collaborator

@ChristopherSteiner ChristopherSteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the extension look good

@oliverschwendener
Copy link
Owner Author

Sorry for not waiting for the review, but as this change touched every possible area I thought it doesn't make much sense to ask for a review from everyone. But thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants