Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Examples for structured outputs and tool use #172

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

ParthSareen
Copy link
Contributor

@ParthSareen ParthSareen commented Dec 5, 2024

Follow up to #171 to add examples for structured outputs

@ParthSareen ParthSareen requested a review from BruceMacD December 5, 2024 00:03
@ParthSareen ParthSareen force-pushed the parth/structured-output-examples branch from 7081915 to 592f1e4 Compare December 5, 2024 19:03
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see some more examples.

It would be nice to add a brief README.md or leading comment to the examples that explains what they are for.

Most of my comments are on structured-outputs-image.ts, but the feedback could be applied to all three examples.

examples/tools/flight-tracker.ts Outdated Show resolved Hide resolved
examples/structured_outputs/structured-outputs-image.ts Outdated Show resolved Hide resolved
examples/structured_outputs/structured-outputs-image.ts Outdated Show resolved Hide resolved
examples/structured_outputs/structured-outputs-image.ts Outdated Show resolved Hide resolved
examples/structured_outputs/structured-outputs-image.ts Outdated Show resolved Hide resolved
examples/structured_outputs/structured-outputs-image.ts Outdated Show resolved Hide resolved
examples/structured_outputs/structured-outputs.ts Outdated Show resolved Hide resolved
examples/structured_outputs/structured-outputs.ts Outdated Show resolved Hide resolved
@ParthSareen
Copy link
Contributor Author

@BruceMacD ended up just adding description to the files itself - will make readme during the examples refactor

Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments, then this is good to go.

examples/tools/calculator.ts Outdated Show resolved Hide resolved
examples/tools/flight-tracker.ts Outdated Show resolved Hide resolved
@ParthSareen ParthSareen merged commit 35a850e into main Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants