feat[vivado]: fix for #426 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates tools/vivado.py to allow the user to skip the
link_design step normally used after reading in a toplevel netlist.
The use case here is when an EDIF netlist, or any other netlist, is read
in as a submodule and is not the toplevel. In this case the link_design
step will fail as Vivado is expecting a netlist with the toplevel name.
In order to bypass the link_design step, use the no_link_design tag when
specifying the netlist in your Core file:
filesets:
netlist:
files:
- cute_a7_core/cute_a7_core.edf: { file_type: edif, tags: [no_link_design] }
shareefj
force-pushed
the
feature/allow_edif_submodules
branch
from
879ce72 to
18c6f9d
Compare
|
This looks good and I think tags are a good fit for this. Thanks for your contributions. Picked and pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates tools/vivado.py to allow the user to skip the link_design step normally used after reading in a toplevel netlist.
The use case here is when an EDIF netlist, or any other netlist, is read in as a submodule and is not the toplevel. In this case the link_design step will fail as Vivado is expecting a netlist with the toplevel name.
In order to bypass the link_design step, use the no_link_design tag when specifying the netlist in your Core file:
filesets:
netlist:
files:
- cute_a7_core/cute_a7_core.edf: { file_type: edif, tags: [no_link_design] }