Updated SpyGlass backend to support features in Synopsys Spyglass v2023.12 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new tool_option (goal_options)
Added goal_options section. Also, in the section where the SystemVerilog (SV09) support is configured, it has been changed to SV for flexibility and generalization
|
@olofk is Edalize no longer in development, or? |
olofk
reviewed
Nov 4, 2024
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| class Spyglass(Edatool): | |||
|
|
|||
| _description = """ Synopsys (formerly Atrenta) Spyglass Backend | |||
| _description = """ Synopsys Spyglass Backend (v2023.12) | |||
There was a problem hiding this comment.
Why is the version hardcoded in the description here?
|
The patch looks mostly fine from a quick look but there are some issues, like the hardcoded version string. The test cases also aren't updated, so the tests are failing now. I also need to inform that this backend uses the old Tool API instead of the new Flow API, and I'm a bit hesitant towards making updates to the old backends. I would much prefer if it was instead rewritten to use the new Flow API. |
|
@olofk wouldn't I still have to change the spyglass tool API in order to create a flow with the extended functionality? Or what do you suggest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the Spyglass backend in the Edalize project. The key changes include:
Support generalized SystemVerilog source files:
Extending support of constraint file types
.sgdc)Support for
set_goal_optionset_goal_optionsThis resolves the issue I opened (#444)