Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"tool list' CLI argument now functional #658

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

phillipe87
Copy link
Contributor

The "tool list" command line argument was returning nothing when invoked.

After quick inspection, I noticed an import statement was missing and was able to make the very minor fix.

@olofk olofk merged commit 20235d2 into olofk:main Dec 26, 2023
14 checks passed
@olofk
Copy link
Owner

olofk commented Dec 26, 2023

Thanks! I completely forgot that command even existed. Come to think of it, we should probably add a similar command for the new Flow API as well.

@phillipe87
Copy link
Contributor Author

Which new Flow API? I am still familiarizing myself with the codebase.

@olofk
Copy link
Owner

olofk commented Jan 11, 2024

The Flow API is technically in Edalize (some info here and on my blog ), but we can select whether to use the old Tool API or the new Flow API from FuseSoC using the flow key in a target of a core file. If the flow key is present, it will use the Flow API, otherwise it will fall back to the old Tool API.

I still have on my todo list to better document how this all fits together, but at least there are some pointers above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants