Skip to content

Commit

Permalink
[SYCL][Devops] Propagate a new secret to containers build (#16384)
Browse files Browse the repository at this point in the history
Extended build containers action with an extra argument which specifies
a password that will be assigned to the `sycl_ci` user created within
containers.

For now this new secret is unused, so this changes is expected to have
no impact on our CI.

This is outlined from #16361 to improve testing for that PR: for
security reasons actions are only invoked from the default branch and
never from a PR branch. Therefore, to actually test that this secret is
properly used without errors we need to update the action first.
  • Loading branch information
AlexeySachkov authored Dec 17, 2024
1 parent da16cd5 commit 6af4e4e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/sycl-containers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ jobs:
file: ${{ matrix.file }}
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
sycl_ci_passwd: ${{ secrets.DOCKER_SUDO_PASSWORD }}
tags: |
ghcr.io/${{ github.repository }}/${{ matrix.file }}:${{ matrix.tag }}-${{ github.sha }}
ghcr.io/${{ github.repository }}/${{ matrix.file }}:${{ matrix.tag }}
Expand Down
4 changes: 4 additions & 0 deletions devops/actions/build_container/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ inputs:
file:
description: "Dockerfile"
required: true
sycl_ci_passwd:
description: "Password to assign to sycl_ci user within a container"
required: true

runs:
using: "composite"
Expand All @@ -41,3 +44,4 @@ runs:
file: ${{ github.workspace }}/devops/containers/${{ inputs.file }}.Dockerfile
secrets: |
github_token=${{ github.token }}
sycl_ci_passwd=${{ inputs.sycl_ci_passwd }}

0 comments on commit 6af4e4e

Please sign in to comment.