Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed expect value of process count in sysman device test #39

Closed
wants to merge 1 commit into from

Conversation

smilczar
Copy link
Contributor

Fixes L0 CTS failure in test run with Compute Aggregation Layer
test_sysman_device --gtest_filter=GivenInvalidComponentCount
WhenRetrievingSysmanHandlesThenActualComponentCountIsUpdated

Related-To: NEO-8927

Signed-off-by: Slawomir Milczarek [email protected]

Fixes L0 CTS failure in test run with Compute Aggregation Layer
test_sysman_device --gtest_filter=GivenInvalidComponentCount
WhenRetrievingSysmanHandlesThenActualComponentCountIsUpdated

Related-To: NEO-8927

Signed-off-by: Slawomir Milczarek <[email protected]>
Copy link

@jchodor jchodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!
Test should not assume how underlying L0 implementation and system works. The only thing the test can assert on is that there is at least 1 process using the GPU (the test itself)

Copy link
Contributor

@gwawiork gwawiork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jemale
Copy link
Contributor

Jemale commented Feb 23, 2024

thanks @smilczar ! This should be merged now with: 0fe953c

@Jemale Jemale closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants