Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase logger test coverage to 100% #1002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

increase logger test coverage to 100% #1002

wants to merge 1 commit into from

Conversation

lplewa
Copy link
Contributor

@lplewa lplewa commented Dec 17, 2024

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@lplewa lplewa requested a review from a team as a code owner December 17, 2024 14:58
@lplewa lplewa force-pushed the 100% branch 2 times, most recently from 8c122c6 to eb2d104 Compare December 17, 2024 17:11
ldorau
ldorau requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI builds fail

test/utils/utils_log.cpp
@@ -110,11 +111,18 @@ const char *env_variable = "";
#ifndef UMF_VERSION
#define UMF_VERSION "test version"
#endif
// This trick to not work on windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe does not ?

test/utils/utils_log.cpp Outdated
@@ -544,3 +581,23 @@ TEST_F(test, log_pmacros) {
EXPECT_EQ(fput_count, expect_fput_count);
EXPECT_EQ(fflush_count, expect_fflush_count);
}

// this test do not work on windows as we cannot mock abort on windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldorau ldorau ldorau requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lplewa @ldorau