[L0 v2] use UMF in urUSMGetMemAllocInfo #2473
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pbalcer this also bumps the UMF version. Is it OK to do this now (and in this PR?)? |
github-actions
bot
added
common
This avoid going to the driver and speeds up UR_USM_ALLOC_INFO_DEVICE query ~2 times in a microbenchmark.
Depends on whether there were any breaking changes between current and latest version. If there weren't, then it's fine. |
The umf_memory_provider_ops_t was modified (oneapi-src/unified-memory-framework@3112e2b), and I believe this is a breaking change. I'll convert the PR to draft until it's safe to bump the UMF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.