[DeviceASAN] Fix urKernelCreateWithNativeHandle segfault #2506
+85
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingcong-wu
reviewed
Dec 24, 2024
| m_KernelMap.emplace(Kernel, | ||
| std::make_shared<KernelInfo>(Kernel, IsInstrumented)); | ||
| return UR_RESULT_SUCCESS; | ||
| std::make_unique<KernelInfo>(Kernel, IsInstrumented)); |
There was a problem hiding this comment.
Why bother using a unique_ptr if there is no ownership change? We can just use raw pointer here.
There was a problem hiding this comment.
We need to manually delete them if it's raw pointer. unique_ptr is more convenient here.
There was a problem hiding this comment.
Then we can just use the object created by the map. It should be deleted when being erased from then map.
|
@oneapi-src/unified-runtime-maintain, please add to 2025.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM: intel/llvm#16473
Since we can't get nullptr when calling
getKernelInfo, I changed the return type of this function to reference.To make it support "urKernelCreateXXX" APIs automatically, I changed
getKernelInfotogetOrCreateKernelInfo, so that we needn't intercept "urKernelCreateXXX" anymore.Sync those changes to msan.