FLIP for new behavior for attachments with entitlements #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisyphusSmiling
approved these changes
Oct 25, 2023
turbolent
reviewed
Oct 31, 2023
Co-authored-by: Bastian Müller <[email protected]>
turbolent
reviewed
Nov 1, 2023
Co-authored-by: Bastian Müller <[email protected]>
6 tasks
turbolent
reviewed
Nov 1, 2023
SupunS
approved these changes
Nov 2, 2023
|
We discussed this in the LDM today, and there was no further feedback. If there are no issues raised by the end of next week, I will close this as Approved. |
dsainati1
commented
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #217
FLIP that proposes a new semantics for how attachments interact with entitlements, that is designed to make using them less of a footgun for developers.