Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of engine.Unit with ComponentManager #6807

Open
tim-barry opened this issue Dec 12, 2024 · 0 comments
Open

Replace uses of engine.Unit with ComponentManager #6807

tim-barry opened this issue Dec 12, 2024 · 0 comments
Assignees
@tim-barry
Labels
Protocol Team: Issues assigned to the Protocol Pillar. Tech Debt

Comments

@tim-barry
Copy link
Contributor

Problem Definition

engine.Unit duplicates some lifecycle functionality, and encourages undesirable design patterns. For new components, we recommend using ComponentManager instead. However, many instances of engine.Unit remain in the codebase.

Proposed Solution

Replace select instances of engine.Unit with ComponentManager. Here is an example of a PR which does this replacement: #4219

See also: https://github.com/onflow/flow-go-internal/issues/7017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tim-barry tim-barry

Labels
Protocol Team: Issues assigned to the Protocol Pillar. Tech Debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tim-barry