Remove engine.Unit from Assigner engine and Fetcher engine #6808
+9
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The engine.Unit was only used for its context. In similar situations, other code uses a context.Background() instead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/pusher-engine-refactor #6808 +/- ##
===============================================================
Coverage 41.23% 41.24%
===============================================================
Files 2062 2062
Lines 182738 182730 -8
===============================================================
+ Hits 75360 75364 +4
+ Misses 101060 101053 -7
+ Partials 6318 6313 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
approved these changes
Dec 14, 2024
zhangchiqing
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6807 for VN Assigner engine and VN Fetcher engine.
In both cases, the engine.Unit was only used for its context. In similar situations, other code uses a context.Background() instead.
Not completely replacing ReadyDoneAware interface with Component yet, due to them still wrapping more complex engines that still use engine.Unit and ReadyDoneAware.