[Access] Pending status returns immediately from send and subscribe transaction statuses #6737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6737 +/- ##
=======================================
Coverage 40.98% 40.99%
=======================================
Files 2103 2103
Lines 184900 184988 +88
=======================================
+ Hits 75783 75832 +49
- Misses 102750 102780 +30
- Partials 6367 6376 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
reviewed
Dec 3, 2024
peterargue
reviewed
Dec 17, 2024
Co-authored-by: Peter Argue <[email protected]>
peterargue
reviewed
Dec 24, 2024
| ctx context.Context, | ||
| tx *flow.TransactionBody, | ||
| requiredEventEncodingVersion entities.EventEncodingVersion, | ||
| ) subscription.Subscription { | ||
| nextHeight, err := b.blockTracker.GetStartHeightFromBlockID(tx.ReferenceBlockID) | ||
| if err := b.sendTransaction(ctx, tx); err != nil { | ||
| b.log.Error().Err(err).Str("tx_id", tx.ID().String()).Msg("failed to send transaction") |
There was a problem hiding this comment.
avoid logging errors for api client issues since this can cause extremely noisy error level logging for larger operators.
Suggested change
| b.log.Error().Err(err).Str("tx_id", tx.ID().String()).Msg("failed to send transaction") | |
| b.log.Debug().Err(err).Str("tx_id", tx.ID().String()).Msg("failed to send transaction") |
| if err != nil { | ||
| return subscription.NewFailedSubscription(err, "could not get start height") | ||
| b.log.Error().Err(err).Msg("failed to retrieve latest block") |
There was a problem hiding this comment.
This should actually throw an exception since the node must have the current sealed block in storage.
e.g.
irrecoverable.Throw(ctx, err)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6573, part of #6767
This PR implements functionality to return a Pending status immediately upon the start of a subscription.