Enable OpenTelemetry Tracing for ChatQnA TGI serving on Gaudi #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louie-tsai
requested review from
lvliang-intel,
ftian1 and
chensuyue
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
|
Please fix the issue reported by CI. |
louie-tsai
force-pushed
the
otlp_chatqna_tgi
branch
from
a4298ad to
45aa2f0
Compare
addressed pre-commit and merge-conflict. should I take care missing dockerfile issue? it doesn't seem to be related to this PR. |
Please merge main branch into yours, and the issues will disappear. |
Spycsh
reviewed
Jan 3, 2025
Spycsh
reviewed
Jan 3, 2025
louie-tsai
force-pushed
the
otlp_chatqna_tgi
branch
from
ac76846 to
28bc80f
Compare
Spycsh
approved these changes
Jan 3, 2025
louie-tsai
force-pushed
the
otlp_chatqna_tgi
branch
from
28bc80f to
f020688
Compare
Signed-off-by: louie-tsai <[email protected]>
louie-tsai
commented
Jan 3, 2025
louie-tsai
force-pushed
the
otlp_chatqna_tgi
branch
from
1866502 to
bccd8b1
Compare
fidencio
reviewed
Jan 3, 2025
Comment on lines
+119
to
+121
| no_proxy: ${no_proxy} | ||
| http_proxy: ${http_proxy} | ||
| https_proxy: ${https_proxy} |
fidencio
reviewed
Jan 3, 2025
| tgi-service: | ||
| image: ghcr.io/huggingface/tgi-gaudi:2.0.6 | ||
| privileged: true |
There was a problem hiding this comment.
Could you please add a comment on why privileged is needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable Jaeger UI and OpenTelemetry tracing for ChatQnA TGI serving on Gaudi.
user could see OPEA, TEI, and TGI open telemetry tracing on Jaeger UI.
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
Jaeger docker image
Tests
Manually testing on Gaudi