bump versions of artifact actions, plint and pdoc compat fixes (#126)

open-atmos · Sep 27, 2024 · b63f69e · b63f69e
1 parent 42bea99
commit b63f69e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/.github/workflows/tests+pypi.yml b/.github/workflows/tests+pypi.yml
@@ -48,7 +48,7 @@ jobs:
         run: |
           pip install pdoc
           pip install -e .
-          python -We -m pdoc -o html PyMPDATA_MPI
+          PDOC_ALLOW_EXEC=1 python -We -m pdoc -o html PyMPDATA_MPI
       - name: Deploy
         if: github.ref == 'refs/heads/main'
         uses: JamesIves/[email protected]
@@ -216,9 +216,9 @@ jobs:
             pip install pytest-cov
           fi
           NUMBA_NUM_THREADS=3 mpiexec $_mpiexec_args -n ${{ matrix.mpi-np }} python -m pytest -p no:cacheprovider $COV_ARGS --timeout=600 --timeout_method=thread -s -vv -We tests/local;
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
-          name: plots
+          name: plots-${{matrix.mpi-np}}
           path: plots
       - if: env.CODECOV_RUN == '1'
         uses: codecov/codecov-action@v4
@@ -246,7 +246,7 @@ jobs:
 
       - run: twine check --strict dist/*
 
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: dist
           path: dist
@@ -255,7 +255,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [package,tests]
     steps:
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           name: dist
           path: dist
@@ -287,9 +287,10 @@ jobs:
     runs-on: ubuntu-latest
     needs: [tests, devops_tests]
     steps:
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
-          name: plots
+          pattern: plots-*
+          merge-multiple: true
           path: plots
       - run: |
           sudo apt install -y librsvg2-bin
@@ -306,7 +307,7 @@ jobs:
               done;
           done;
 
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: anims
           path: plots/*-anim.gif

diff --git a/PyMPDATA_MPI/impl/boundary_condition_commons.py b/PyMPDATA_MPI/impl/boundary_condition_commons.py
@@ -1,4 +1,4 @@
-# pylint: disable=too-many-arguments
+# pylint: disable=too-many-positional-arguments,too-many-arguments
 """ boundary_condition common functions """
 
 from functools import lru_cache

diff --git a/PyMPDATA_MPI/impl/mpi_boundary_condition.py b/PyMPDATA_MPI/impl/mpi_boundary_condition.py
@@ -17,7 +17,7 @@ def make_get_peer(_, __):
         """returns (lru-cached) numba-compiled callable."""
         raise NotImplementedError()
 
-    # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-positional-arguments,too-many-arguments
     def make_scalar(self, indexers, halo, dtype, jit_flags, dimension_index):
         """returns (lru-cached) Numba-compiled scalar halo-filling callable"""
         if self.__mpi_size_one:

diff --git a/PyMPDATA_MPI/mpi_periodic.py b/PyMPDATA_MPI/mpi_periodic.py
@@ -24,7 +24,7 @@ def __init__(self, size, mpi_dim):
 
         super().__init__(size=size, base=Periodic, mpi_dim=mpi_dim)
 
-    # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-positional-arguments,too-many-arguments
     def make_vector(self, indexers, halo, dtype, jit_flags, dimension_index):
         """returns (lru-cached) Numba-compiled vector halo-filling callable"""
         if self.worker_pool_size == 1: