fix: sidebar completion for completable XBlocks with children #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to create a completable XBlock with children. An example is the Library Content Block with the `MARK_LIBRARY_CONTENT_BLOCK_COMPLETE_ON_VIEW` feature toggle. The sidebar should use the same mechanism as the `BlockCompletionTransformer` and the `edx-completion` library. It means that we should treat: 1. An aggregator XBlock as completed only when all its children are completed. 2. A completable XBlock as completed when it is directly marked as completed (without checking the completion of its children).
The Redwood branch is still using Python 3.8 for unit tests. This commit can be safely ignored in Sumac.
Agrendalath
force-pushed
the
agrendalath/sidebar-completion-of-completable-blocks-with-children-redwood
branch
from
e6d0065 to
1ddf5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of openedx#36043.
Private-ref: BB-8469 (temporary)