Added proxy functionality #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/ee/ria/DigiDoc/android/main/settings/proxy/SettingsProxyView.java
Fixed
Show fixed
Hide fixed
app/src/main/java/ee/ria/DigiDoc/android/main/settings/SettingsDataStore.java
Fixed
Show fixed
Hide fixed
| throw new CentralConfigurationException("Something went wrong during fetching configuration", e); | ||
| if (httpClient != null) { | ||
| CompletableFuture.runAsync(() -> { | ||
| Call call = httpClient.newCall(request); |
Check warning
Code scanning / CodeQL
Android missing certificate pinning Medium
| if (encryptedPreferences != null) { | ||
| SharedPreferences.Editor editor = encryptedPreferences.edit(); | ||
| editor.putString(resources.getString(R.string.main_settings_proxy_password_key), password); | ||
| editor.commit(); |
Check failure
Code scanning / CodeQL
Cleartext storage of sensitive information using `SharedPreferences` on Android High
There was a problem hiding this comment.
Fixed using EncryptedSharedPreferences ( https://developer.android.com/reference/androidx/security/crypto/EncryptedSharedPreferences )
martenrebane
force-pushed
the
MOPPAND-1019
branch
from
3b26979 to
91ab175
Compare
martenrebane
force-pushed
the
MOPPAND-1019
branch
3 times, most recently
from
21ddef2 to
bb6cb1e
Compare
martenrebane
force-pushed
the
MOPPAND-1019
branch
2 times, most recently
from
3b62a6e to
328b673
Compare
martenrebane
force-pushed
the
MOPPAND-1019
branch
from
328b673 to
217fa75
Compare
martenrebane
force-pushed
the
MOPPAND-1019
branch
from
4a1eb0a to
6cacfd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marten Rebane [email protected]