Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pipelines #20

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

update pipelines #20

wants to merge 4 commits into from

Conversation

ymzhang0319
Copy link
Collaborator

No description provided.

zengyh1900
zengyh1900 requested changes Oct 11, 2024
View reviewed changes
app.py Outdated Show resolved Hide resolved
foleycrafter/models/audio_generator.py Outdated Show resolved Hide resolved
foleycrafter/models/audio_generator/attention.py Outdated Show resolved Hide resolved
foleycrafter/models/audio_generator/attention_processor.py Outdated Show resolved Hide resolved
@zengyh1900
Copy link
Collaborator

hi @ymzhang0319
it seems that there are multiple files that are directly copied from diffusers with minor changes. I don't think this is a good style. Please only implement the necessary parts and import other modules.

@ymzhang0319
Copy link
Collaborator Author

hi @ymzhang0319 it seems that there are multiple files that are directly copied from diffusers with minor changes. I don't think this is a good style. Please only implement the necessary parts and import other modules.

I deleted the copied files and only keep the modified files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengyh1900 zengyh1900 Awaiting requested review from zengyh1900

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymzhang0319 @zengyh1900