Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-511] Add new configuration files for FCOS3D #2679

Open
wants to merge 7 commits into
base: dev-1.x
Choose a base branch
from

Conversation

0zzx0
Copy link

@0zzx0 0zzx0 commented Aug 2, 2023

Add new configuration files for FCOS3D.

Based on open-mmlab/OpenMMLabCamp#511

Motivation

MMEngine establishes a renovated configuration infrastructure enabling us to tailor the configuration files according to requirements.

Modification

  • Add FCOS3D config python files in mmdet3d/configs/fcos3d/
  • All added config files adapt new version of config.

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage is 19.58% of modified lines.

❗ Current head c1386bd differs from pull request most recent head 6c40aa9. Consider uploading reports for the commit 6c40aa9 to get more accurate results

Files Changed Coverage
mmdet3d/datasets/transforms/formating.py ø
mmdet3d/models/necks/second_fpn.py ø
mmdet3d/visualization/local_visualizer.py 8.33%
mmdet3d/datasets/transforms/loading.py 50.00%
mmdet3d/engine/hooks/visualization_hook.py 71.42%
mmdet3d/__init__.py 100.00%
mmdet3d/datasets/transforms/transforms_3d.py 100.00%
mmdet3d/version.py 100.00%

📢 Thoughts on this report? Let us know!.

@sunjiahao1999
Copy link
Collaborator

@0zzx0 Fix UT.

@0zzx0 0zzx0 force-pushed the fcos3d_newconfig branch from 39a08e1 to ea81e92 Compare August 10, 2023 10:09
@0zzx0
Copy link
Author

0zzx0 commented Aug 11, 2023

@0zzx0 Fix UT.

@sunjiahao1999 I have fixed, please review again, thanks.

@OpenMMLab-Assistant-004

Hi @0zzx0,

We'd like to express our appreciation for your valuable contributions to the mmdetection3d. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!


# optimizer
optim_wrapper.update(dict(optimizer=dict(lr=0.001)))
load_from = 'work_dirs/fcos3d_nus/latest.pth'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this path should be set as None. If user need to modify it, then should add comments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. This path is because the old config file has this line. I will delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants