Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support PGD and multi-view FCOS3D++ on Waymo #2835

Merged
merged 41 commits into from
Jan 4, 2024

Conversation

sunjiahao1999
Copy link
Collaborator

@sunjiahao1999 sunjiahao1999 commented Dec 5, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Support PGD front-of-view / multi-view on Waymo
Support multi-view FCOS3D++ on Waymo
Update Waymo-mini and waymo_infos_xxx.pkl link and related docs

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@sunjiahao1999 sunjiahao1999 changed the base branch from main to dev-1.x December 5, 2023 08:20
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ JingweiZhang12
✅ sunjiahao1999
❌ sjh


sjh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sunjiahao1999 sunjiahao1999 changed the title [WIP] Waymo Total refactor [Feature] Support PGD and multi-view FCOS3D++ on Waymo Dec 28, 2023
@sunjiahao1999 sunjiahao1999 requested a review from ZwwWayne January 3, 2024 12:06
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (762e3b5) 47.24% compared to head (be43c4d) 47.26%.
Report is 2 commits behind head on dev-1.x.

Files Patch % Lines
mmdet3d/models/detectors/multiview_dfm.py 29.03% 22 Missing ⚠️
mmdet3d/models/detectors/dfm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2835      +/-   ##
===========================================
+ Coverage    47.24%   47.26%   +0.01%     
===========================================
  Files          277      277              
  Lines        23416    23415       -1     
  Branches      3657     3655       -2     
===========================================
+ Hits         11063    11067       +4     
+ Misses       11640    11635       -5     
  Partials       713      713              
Flag Coverage Δ
unittests 47.26% <28.12%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZwwWayne ZwwWayne merged commit 88b8694 into open-mmlab:dev-1.x Jan 4, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants