-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Save the memory to visualization backends #974
[Enhancement] Save the memory to visualization backends #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log_str
means the logs displayed in the terminal or logs dumped into xxx.log
. As described in #916, we want to see memory
information in the saved JSON file, Tensorboard or WandB, therefore we should add memory
filed to tag, rather than extend the log_str
yes,but i read the code and docs, i can't find which code to generate json or other file and format the display information. |
Hi, you can modify the following lines mmengine/mmengine/runner/log_processor.py Lines 199 to 200 in b1b1f53
to if is_cuda_available():
max_memory = self._get_max_memory(runner)
log_str += f'memory: {max_memory} '
tag['memory'] = max_memory
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #974 +/- ##
=======================================
Coverage ? 76.51%
=======================================
Files ? 138
Lines ? 10852
Branches ? 2168
=======================================
Hits ? 8303
Misses ? 2191
Partials ? 358
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
add memory in other log
Modification
add memory in other log
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist