Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Replace markdownlint with mdformat for avoiding installing ruby #298

Merged
merged 7 commits into from
May 19, 2022

Conversation

LeoXing1996
Copy link
Collaborator

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #298 (1a15109) into master (10cd8f1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files         145      145           
  Lines       10912    10912           
  Branches     2145     2145           
=======================================
  Hits         8160     8160           
  Misses       2214     2214           
  Partials      538      538           
Flag Coverage Δ
unittests 74.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/__init__.py 70.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cd8f1...1a15109. Read the comment docs.

Copy link
Collaborator

@plyfager plyfager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of MMCV and MMCLS changed. mdformat did these?

@LeoXing1996
Copy link
Collaborator Author

The version of MMCV and MMCLS changed. mdformat did these?

I did this manually. Otherwise, all unit tests will be failed because in __init__.py we check the mmcv version.

@LeoXing1996 LeoXing1996 merged commit 6bce6ed into open-mmlab:master May 19, 2022
@LeoXing1996 LeoXing1996 deleted the use-mdformat branch June 1, 2022 02:04
LeoXing1996 added a commit that referenced this pull request Jul 16, 2022
#298)

* use mdformat in pre-commit hook

* revise mmcv version in requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants