Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to find if hostboot has transitioned control to host #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deepakala-k
Copy link
Contributor

Utilizing the xyz.openbmc_project.State.Host interface to ascertain the host's operational status becomes less accurate when transitioning from hostboot to PHYP. During the period when PHYP is initializing and not yet fully operational, the host state is erroneously presumed to be in hostboot. In situations where PHYP encounters initial boot difficulties and activates a watchdog timer, this watchdog misinterprets the issue as a problem with hostboot.

To address this, there exists a core scratch register that undergoes an update by hostboot just before transferring control to PHYP. We have devised a method that leverages this register to determine whether the transition to PHYP has already occurred.

By implementing this functionality, we can accurately determine whether control has transitioned to PHYP, allowing for more precise reporting of the host's state.

libphal/libphal.H Outdated Show resolved Hide resolved
libphal/phal_pdbg.C Outdated Show resolved Hide resolved
Copy link
Contributor

@Swarnendu-R-C Swarnendu-R-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

libphal/phal_pdbg.C Outdated Show resolved Hide resolved
libphal/phal_pdbg.C Outdated Show resolved Hide resolved
libphal/phal_pdbg.C Outdated Show resolved Hide resolved
libphal/phal_pdbg.C Outdated Show resolved Hide resolved
@deepakala-k deepakala-k changed the title Add function to find if host is transitioning to PHYP Add function to find if hostboot has transitioned control to host Sep 28, 2023
Copy link
Contributor

@Swarnendu-R-C Swarnendu-R-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A query and a suggestion

libphal/libphal.H Outdated Show resolved Hide resolved
libphal/phal_pdbg.C Outdated Show resolved Hide resolved
libphal/libphal.H Outdated Show resolved Hide resolved
@deepakala-k deepakala-k force-pushed the transitioned_to_phyp branch 2 times, most recently from 657ad2c to 3ff22f0 Compare October 4, 2023 08:38
Utilizing the xyz.openbmc_project.State.Host interface to ascertain the
host's operational status becomes less accurate when transitioning from
hostboot to host. During the period when host is initializing and not
yet fully operational, the host state is erroneously presumed to be in
hostboot. In situations where host encounters initial boot difficulties,
and the watchdog time is hit as the boot up process has not completed
within a specific time, this watchdog misinterprets the issue as
a problem with hostboot.

To address this, there exists a core scratch register that undergoes an
update by hostboot just before transferring control to host. We have
devised a method that leverages this register to determine whether the
transition to host has already occurred.

By implementing this functionality we can determine which booting
subsystem is failed or stopped responding, and the dump can be extracted
from the right subsystem.

Signed-off-by: Deepa Karthikeyan <[email protected]>
@deepakala-k deepakala-k force-pushed the transitioned_to_phyp branch from 3ff22f0 to eb51677 Compare October 4, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants