-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check workflows for issues during CI #1916
Conversation
This PR adds an Actionlint workflow to validate GH actions as per open-quantum-safe#1866 This is an updated version of PR open-quantum-safe#1880, taking into account the discussion on that contribution. Signed-off-by: JP Lomas <[email protected]>
@SWilson4 should this PR trigger |
Documents actionlint use as part of CI basic workflow including instructions of running locally. Signed-off-by: JP Lomas <[email protected]>
I was expecting it to, even on a PR from a fork... let me see if I can figure out what's going on. |
Ironically, it looks like an invalid workflow error: https://github.com/open-quantum-safe/liboqs/actions/runs/10789716344/workflow |
Co-authored-by: Spencer Wilson <[email protected]> Signed-off-by: JP Lomas <[email protected]>
Well spotted... got as far as seeing it was a checkout problem. Hopefully that's sorted it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks very much for this improvement, JP!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging! Thanks again for the contribution, @jplomas. |
This PR adds an Actionlint workflow to validate GH actions as per #1866
This is an updated version of PR #1880, taking into account the discussion on that contribution.
Actionlint checking would have protected against the changes fixed in #1869 and #1902, e.g. (for the latter):
* [ ] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)* [ ] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)