-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Spanish (es) translations #115
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for sauced-intro ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @samucodesh! :) Thanks for your translation! :) Can you link the corresponding issue in the Related Documents & Tickets section of your PR form? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samucodesh! :) The only piece of feedback is that we want to keep the word "open source" in English so turn código abierto
back into English please.
It took me several weeks to update my branch, I look forward to your feedback |
updated chapter translation based on this [PR](open-sauced#181)
Hey @samucodesh, Thank you so much for the PR and for your initiative to update this branch with our latest changes! We truly appreciate it! ✨ We're sorry that our @open-sauced/docs team still have no time and resources to review your PR. Also, heads up, we will have more (big) updates to come in the next few months. So, we're wondering if you're interested in hosting and maintaining this Spanish translation yourself in your forked repo as one of our community translations. The benefit of doing so are:
Please let us know what do you think and we can discuss further from there. Thank you! 😊 |
Absolutely! I completely understand about the @open-sauced/docs team's workload. I'd be thrilled to host and maintain the Spanish translation in my forked repo as a community translation. This would be a fantastic learning experience for me, and I'm confident I can get the Spanish version out quickly. I'm also happy to handle future updates as they come. Thank you so much for the opportunity! |
Thank you so much for your interest! ✨ This will be the pilot of our community translations and I'm as much as excited as you! 🥳 That said, you can start with getting ready to maintain and host the Spanish translation on your forked repository. 🙌🏽 Please be noted, this is also new for me, so I still try to find the best way to do this. But I'll do my best to support you whenever I can! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
Hey @samucodesh, Heads up. I'm coverting this PR as draft as we're discussing on moving this as community translations. Thanks! 🙂 |
…en-source' [Related PR](open-sauced#185) This commit translates the latest changes to the 'How to Contribute to Open Source' file These were some of the changes in the file: - Fork the Repository - Clone the Forked Repository - Create a New Branch - Make Changes - Run the Changes Locally - Add and Commit the Changes - Push the Changes - Working with a Pull Request
[Related PR](open-sauced#194) This commit adds a link to the Job Seekers Guide within the 'La Salsa Secreta' file of the Spanish translation. This provides additional resources for individuals seeking employment opportunities in the tech industry.
Description
This PR adds a Spanish translation for the course. This will help Spanish and Latin Americans
contributors start their journey towards open source.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #116
Mobile & Desktop Screenshots/Recordings
README
navbar
sidebar
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?