Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pt-br translation #35
feat: Add pt-br translation #35
Changes from all commits
cbfcd03
6f52905
53ed47b
1a9e09d
4b8fc29
32a505f
09aeebd
7bff80f
094a1c2
6784c43
f86fb42
6f3700f
9d78d68
e1689f8
77faf4f
1bb8a5f
cb6d45a
044f045
8bb5752
d8e3105
cb9cca7
f4b044e
cad6ded
f4b6921
79a0821
4f9742a
ac3f323
7c60607
40830c4
e08fbfa
1b65d58
fb816e9
184811b
0927c01
760863d
4ebb7c5
640bed2
4f9a50c
6e4916b
6448a66
0090ac5
0c9f6b8
26d0bf2
356bb67
d0f5220
7490f27
fb06f85
b5fc9d0
80bc856
9fe7ca8
9c2658d
d39f50a
066d0b6
c12475d
f14ab11
5da4df9
40b46b7
9fa6b60
f7d1d20
ef02874
0e93209
7c9aa16
3b77466
19bc12c
6009f7f
386086c
93d8fa2
9873584
9be8687
0355c67
30765c1
8302b4a
0c10c43
0b15f13
0f68d09
5e66e79
3bb7a2d
cc7f5cb
6fa0158
d44fa5c
cb5c6f8
701d84c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, whatever change is related to French translation, there should be another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, whatever change is related to French translation, there should be another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, whatever change is related to French translation, there should be another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get it @antonio-pedro99, but @BekahHW requested to get those fixed right at the moment. In the future, we'll do this. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CBID2 I think you misunderstood. I was looking at the wrong translation. It should be in a separate PR. I didn't realize that got merged in. I know I caught that in the French PR and since I don't speak either of these languages, I thought I was looking at the br translation. I also wonder if there were other issues that didn't get resolved in that French PR. That's another reason an issue should be made for that. This is one of the complicated parts of having translations when we don't have a maintainer team to support reviewing the PRs bc they don't speak the language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BekahHW @CBID2 @antonio-pedro99,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BekahHW, thanks for clarifying this. @antonio-pedro99, I'll revert the commits that contain the changes in French. @geoffreylgv, I'll create a separate issue for the French PR and we can create it. Sound good?