Upgrade dependencies in protobuf image #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
commented
Jun 1, 2022
Comment on lines
-41
to
-49
| ARG PROTOBUF_C_VERSION | ||
| RUN mkdir -p /protobuf-c && \ | ||
| curl -sSL https://api.github.com/repos/protobuf-c/protobuf-c/tarball/v${PROTOBUF_C_VERSION} | tar xz --strip 1 -C /protobuf-c && \ | ||
| cd /protobuf-c && \ | ||
| export LD_LIBRARY_PATH=/usr/lib:/usr/lib64 && \ | ||
| export PKG_CONFIG_PATH=/usr/lib64/pkgconfig && \ | ||
| ./autogen.sh && \ | ||
| ./configure --prefix=/usr && \ | ||
| make && make install DESTDIR=/out |
There was a problem hiding this comment.
"C" generated files are not used by our community.
tigrannajaryan
approved these changes
Jun 1, 2022
arminru
approved these changes
Jun 2, 2022
codeboten
reviewed
Jun 6, 2022
There was a problem hiding this comment.
Please fix
make[1]: Entering directory '/grpc-web/javascript/net/grpc/web/generator'
g++ -std=c++11 -I/usr/local/include -pthread -c -o grpc_generator.o grpc_generator.cc
g++ grpc_generator.o -L/usr/local/lib -lprotoc -lprotobuf -lpthread -ldl -static -o protoc-gen-grpc-web
/usr/lib/gcc/x86_64-alpine-linux-musl/10.3.1/../../../../x86_64-alpine-linux-musl/bin/ld: cannot find -lprotoc
/usr/lib/gcc/x86_64-alpine-linux-musl/10.3.1/../../../../x86_64-alpine-linux-musl/bin/ld: cannot find -lprotobuf
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:32: protoc-gen-grpc-web] Error 1
make: *** [Makefile:9: install-plugin] Error 2
|
@bogdandrutu is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]